"GrafZahl" posted a comment on MediaWiki.r107277. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107277#c28520
Commit summary for MediaWiki.r107277: Simplified profiling by wrapping wfProfileIn/Out calls in a class. Profile all methods that call wfShellExec(), explicitly or implicitly. GrafZahl's comment: Hm, I got the idea from MediaWiki's ScopedLock class, so it's got to work, right? Here is what the PHP docs say: http://www.php.net/manual/en/language.oop5.decon.php#language.oop5.decon.destructor The wording could be clearer, but I guess in <blockquote> The destructor method will be called as soon as there are no other references to a particular object, or in any order during the shutdown sequence. </blockquote> the or part applies to the shutdown sequence only. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
