"Krinkle" posted a comment on MediaWiki.r107329.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107329#c28535
Commit summary for MediaWiki.r107329:
[Core JS] Remove long deprecated globals 'ta' and 'akeytt'
* Not used anywhere in ./phase3/
* Not used anywhere in ./extensions/
* Deprecated in MediaWiki 1.16 according to HISTORY
Krinkle's comment:
Yes, but that was 2 years ago. Pretty much every single script ever written
before 2011 most likely has some deprecated parts in them. Some harmless, some
slowing-down (doing redundant stuff), some alarming and breaking.
In the [[m:User:Krinkle/2011_Resource_Walker|2011 Resource Walker]] edition of
''Tour dé Wiki'' it became clear that many wikis have scripts that depend on
the HTML structure, even the phrasing in html elements from Special pages and
actions that were loaded through XMLHttpRequests, and are calling several
functions that may or may not exist anymore. Either they were silently failing
or throwing exceptions, but they definitely needed to be ported to new
mediaWiki.js library and other ResourceLoader habbits.
If a script is still referring to global <code>ta</code> and/or
<code>akeytt</code> then I'm 99% sure that this script:
* Either is breaking already for other reasons
* Is in it's entirety redundant (there were (before the Tour dé Wiki) many
wikis that had {{Blue|MediaWiki:Monobook.js}} pages with a long list of
<code>ta['....'] = ...;</code> definitions. If those throw a ReferenceError
now, that's harmless as the script isn't doing anything anyway.
Anything already ported to ResourceLoader will no longer have these globals
used, so this shouldn't break anything. And anything not ported already should
be ported anyway.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
