"Ryan lane" posted a comment on MediaWiki.r107416. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107416#c28572
Commit summary for MediaWiki.r107416: Default to return '' at the bottom of the switch Remove the redundant else statements for return false/array -47 lines Ryan lane's comment: There are no break statements in any of the cases. If return '' is moved to the bottom, then breaks need to be added to those cases. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
