"GWicke" changed the status of MediaWiki.r107463 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107463#c28610
Old Status: new > New Status: ok Commit summary for MediaWiki.r107463: refactor parser to ParseThingy in different module, can be invoked with command line utility parse.js GWicke's comment: Thanks for cleaning this up! We'll need different pipelines for WikiDom vs. HTML DOM and viewing vs. editing. We could create those by passing an argument to the constructor, and then calling a generic .process() method on the pipeline to set things in motion. This would allow us to cache the pipeline. Alternatively, different methods (.parseToWikiDom, .parseToHTMLDom etc) could be used to construct the corresponding pipeline and cache it internally. In general, the stage setup tends to be much more expensive than just reconfiguring pipeline stage event registrations. The PEG tokenizer in particular is very slow to build. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
