"Krinkle" posted a comment on MediaWiki.r107556. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107556#c28647
Commit summary for MediaWiki.r107556: Use jqueryMsg wikitext parser to parse interface messages at client side. Support for PLURAL in javascript. Krinkle's comment: Well, we can move mw.message as-is (including the Message constructor function and it's prototype) into a separate module, but I'm not sure we should also add the dependency to <code>mw.jqueryMsg</code> to it. Right now it's not used anywhere in core, why load it on all pages by default ? I don't see the problem with modules that need the parser to add "<code>'dependencies' => 'mw.jqueryMsg'</code>" and use it. If it would then be used by an extension that is loaded on all pages, that's fine, but I don't think we should literally fix that it should be loaded on all pages. That takes away from the ResourceLoader principle of loading what is needed for the code that is currently on the page. Also note that moving the base mw.message into a separate module means that all usages everywhere of "mw.msg" need to add "mediawiki.message" do it's dependencies, that's going to cause breakages. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
