"Krinkle" posted a comment on MediaWiki.r99088.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99088#c28662
Commit summary for MediaWiki.r99088:
Partly revert r99083 because the new behaviour is still buggy...
Krinkle's comment:
* diff between before r99083 and after this:
{{viewvc|trunk/phase3/skins/vector/vector.js|99088|86963}}
Looks good. Although you didn't introduce it, I'd recommend using <code>$( self
).find( '.menu:first' )</code> instead of <code>$( '.menu:first', self
)</code>. Reason being that the former is easier to read, and is also faster
because jQuery doesn't have to re-create the object for it and it actually does
a call to itself in the form of <code>$( context ).find( selector );</code>.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
