"Tim Starling" changed the status of MediaWiki.r97997 to "ok" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97997#c28665
Old Status: new
> New Status: ok
Commit summary for MediaWiki.r97997:
SpecialMoodBarFeedback: Implement paging, and fix the form target for ugly URLs
Tim Starling's comment:
<pre>
+ if ( $offset !== false ) {
+ $arr = explode( '|', $offset, 2 );
+ $ts = $dbr->addQuotes( $dbr->timestamp( $arr[0] ) );
+ $id = isset( $arr[1] ) ? intval( $arr[1] ) : 0;
+ $conds[] = "mbf_timestamp < $ts OR (mbf_timestamp = $ts
AND mbf_id <= $id)";
+ }
</pre>
I think IndexPager or an IndexPager subclass would be a good place to put a lot
of this kind of boilerplate. The idea of the Pager hierarchy was to factor out
the tedious code that efficient paging requires.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
