"Tim Starling" changed the status of MediaWiki.r98001 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98001
Old status: new
> New status: ok
Commit summary for MediaWiki.r98001:
SpecialMoodBarFeedback: Add nojs paging links
* Add images for left and right arrows, enabled and disabled. Used the images
Brandon uploaded to mediawiki.org
** The naming is a bit weird. I would've preferred to call them
page-{active,disabled}-{left,right}.png , but had to use {ltr,rtl} instead
because ResourceLoader instructs CSSJanus to flip ltrand rtl in URLs, but not
to flip left and right in URLs. I considered changing that behavior but didn't
like the backwards compatibility implications. I may revisit that later
* Add messages for "More" (which was hardcoded all the time; for shame!),
"Newer" and "Older"
* Output a link or a <span>, depending on whether there are results in the
given direction. Going back (the "Newer" link) is not yet functional
* Tweak the CSS
** Share common rules between More, Newer and Older
** Show either More or Newer&Older, depending on whether JS is enabled. This
requires r95318 which is currently only in trunk
** Made the text for disabled "links" (really spans) gray. Pulled the color
value from the PNG
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
