"Nikerabbit" changed the status of MediaWiki.r107604 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107604
Old status: new
> New status: ok
Commit summary for MediaWiki.r107604:
[mediawiki.debug] apply code conventions
* Quote "class"-key in object literals. It's stupid that JavaScript does not
allow reserved words in this position but that's the way it is. As of ES5
(which Chrome/Firefox already started to implement) this is now part of the
standard and no longer have to be quoted, still required for the browsers we
support though.
* Fix usage of Array to Object. Arrays are for numeral keys only.
* Make usage of $() for building elements from HTML strings more consistent.
Using shortag syntax for new elements creation. And valid HTML for snippets (as
supposed to $("<div></div>") and $("<span class="foo">")). valid HTML is always
okay, but shortag should only be used for creating plain elements (which jQuery
recognizes and calls document-createElement for. Anything else goes into
innerHTML which causes problems in browsers that require it to be valid and
don't apply normalization.
* Remove empty style rule
* Moving declaration inside for-blocks to the function scope. JavaScript
doesn't have just-in-time variables or block scope, only function scope.
* Apply general code conventions
* Follows-up r105122
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
