"Nikerabbit" changed the status of MediaWiki.r107625 to "fixme" and commented
it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107625#c28676
Old Status: new
> New Status: fixme
Commit summary for MediaWiki.r107625:
now beta - cleaned up code - added to credits - time comparison code still
needs revamp - ready for feedback and tweaks welcome
Nikerabbit's comment:
<pre> foreach ( $res as $row ) {
$edittime[] = $row->rev_timestamp;
}
+ $edittime = array();
+ foreach ( $res as $row ) {
+ $edittime[] = $row->rev_timestamp;
+ }
</pre>
Looks like broken merge.
There are some very long lines in this commit.
+ $response = file_get_contents( $bitly );
We have Http::get/post for doing that. And the function name and comment seem
to be outdated.
+ $tweet_text = substr( $tweet_text, 0, $tweet_text_count
);
Use $language::truncate() to do it in multibyte safe way.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
