"GrafZahl" changed the status of MediaWiki.r103202 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103202#c28703
Old Status: ok > New Status: fixme Commit summary for MediaWiki.r103202: * Factorise common code in ImagePage::delete() and allow normal page deletion if $wgUploadMaintenance is true * Moved $wgUploadMaintenance check after permissions and read only, so that the user doesn't think the error is temporary if he both doesn't have the permission and $wgUploadMaintenance is true * Show normal error page when $wgUploadMaintenance and added a message for the error title * Moved watchlist updating to FileDeletForm::execute(), it has nothing to do in doDelete() (would also be executed for api requests, etc.) * Added $user parameter to FileDeletForm::doDelete() to pass the user doing the action * Use WikiPage instead of Article GrafZahl's comment: "Undefined variable title", when trying to delete a file and changing the watched status. Did you mean <code>$this->title</code> in lines 104 and 106? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
