"Krinkle" changed the status of MediaWiki.r102301 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102301#c28772
Old Status: ok > New Status: fixme Commit summary for MediaWiki.r102301: Fix Bug #32047: in table with class="sortable", thead is before caption Apply fomafix's patch for jquery.tablesorter.js (also reported upstream: https://forum.jquery.com/topic/in-table-with-class-sortable-thead-is-before-caption (currently in moderation) Krinkle's comment: This commit changes behavior on tables with multiple tbody's. <code>$table.prepend( $thead );</code> inserts as first child of the table element(s). <code>$table.children('tbody').before( $thead );</code> inserts it before the tbody element(s) in the table element(s). Difference being that the latter will clone the <code>$thead</code> one or more time for each <code>tbody</code> element, of which there can me multiple. The rationale for this revision is totally right, but I suggest using <code>.find( 'tbody:first' )</code> instead of <code>children( 'tbody' )</code> to avoid this side affect. See also * http://jsfiddle.net/umRJr/157/ (prepend) * http://jsfiddle.net/umRJr/156/ (children.before) * http://jsfiddle.net/umRJr/159/ (find first.before) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
