"Duplicatebug" posted a comment on MediaWiki.r107771. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107771#c28780
Commit summary for MediaWiki.r107771: Follow-up r107769: * do the same with getTouched(); removed its $db param since it's pretty useless now (and nothing is using it actually) * also set $mIsNew in loadFromRow() when there's no DB row (i.e. the page doesn't exist) Also forgot to say that I moved both functions near other related functions. Duplicatebug's comment: It is better, to select the <tt>page_counter</tt> field only when needed ($wgDisableCounters is not true) and to set that field only when allowed. Unfortunately Title::getCount does not respect that setting, too. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
