"Aaron Schulz" changed the status of MediaWiki.r107945 to "ok" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107945#c28873

Old Status: new
> New Status: ok

Commit summary for MediaWiki.r107945:

Revert r107769, r107771, r107825, r107840, r107927, r107934

Title objects are meant to be dumb value objects; we shouldn't add to their 
internal state like this, but should be working to remove the bits already in 
there like the article ID.
Preloading information like this can make sense, but probably belongs in 
WikiPage, not Title.

Aaron Schulz's comment:

This approach makes sense.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to