"Hashar" posted a comment on MediaWiki.r107954. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107954#c28902
Commit summary for MediaWiki.r107954: Followup r107862 Fix bug that caused a PHP notice Vertical-align:top on callers in the console Hashar's comment: You are counting things twice: <tt>count( self::$log )</tt> That logic to check if the warning is a duplicate deprecation should be in deprecated(). That looks hacky this way. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
