"Catrope" changed the status of MediaWiki.r107876 to "ok" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107876#c28932

Old Status: new
> New Status: ok

Commit summary for MediaWiki.r107876:

Bug 33482 - Api incorrectly calls ApiBase::parseMultiValue if allowed values is 
given as an array

Simply means that if you have an array of acceptable values and you only accept 
one at a time, you can have pipes in the allowed values.

Catrope's comment:

The bug was a bit misnamed. Not calling parseMultiValue() was a possible 
solution to Niklas's problem, this is another solution, and it's valid. Setting 
back to OK.

(FTR, the problem was that parameters with PARAM_TYPE set to an array of 
allowed values but PARAM_ISMULTI set to false would not take values containing 
pipe characters properly.)

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to