"Johnduhart" posted a comment on MediaWiki.r101246. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101246#c29001
Commit summary for MediaWiki.r101246: * In FlaggedRevision::newFromStable(): Removed redundant fr_page_id = fp_page_id cond as fr_rev_id is the PK now. Also added some sanity conditions. * Cleaned up rev_deleted query to use bitAnd(). * Added FlaggedRevision::newFromId() function. Johnduhart's comment: <pre>+ private $mRevision; // base revision + private $mTemplates; // included template versions + private $mFiles; // included file versions + private $mFileSha1; // file version sha-1 (for revisions of File pages) + private $mFileTimestamp; // file version timestamp (for revisions of File pages) + /* Flagging metadata */ + private $mTimestamp; // review timestamp + private $mQuality; // review tier + private $mTags; // review tags + private $mFlags; // flags (for auto-review ect...) + private $mUser; // reviewing user + private $mFileName; // file name when reviewed + /* Redundant fields for lazy-loading */ + private $mTitle; // page title + private $mStableTemplates; // stable versions of template version used + private $mStableFiles; // stable versions of file versions used</pre> Spaces? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
