"Nikerabbit" posted a comment on MediaWiki.r108184.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108184#c29041
Commit summary for MediaWiki.r108184:
ResourceLoader: Add an experimental option to move the main module loading
queue (the bottom queue) from the bottom of the <body> up into the <head> ,
while still being loaded asynchronously. This makes them load earlier, which
should make the page load faster. This is the product of a long discussion on
bug 27488
* Added a "blocking" state to mw.loader . When loading scripts while the
document is not ready, the loader will use document.write() if blocking is
true, and append to the <body> or the <head> if blocking is false. If the
document is ready, the loader will always append to the <body>
* Enable blocking mode while loading the top queue, and disable it after. This
ensures that modules in the top queue are still loaded in a blocking way as
they were before
* If $wgResourceLoaderExperimentalAsyncLoading is true, the bottom queue is
also loaded in the head, but with blocking mode disabled. Otherwise, it's
loaded at the bottom of the <body> as before
* scripts-only and messages-only requests need special treatment:
** in the top queue, they can continue to use <script src="..."> tags because
they are blocking
** if the bottom queue is at the bottom of the <body> (experimental async
loading disabled), they can continue to use <script src="..."> tags as before
** if the bottom queue is in the <head> (experimental async loading enabled),
they cannot use <script src="..."> tags, because those would block. Instead,
call mw.loader.load() on the load.php URL
Nikerabbit's comment:
Some examples which I think are all caused by this:
<pre>
3 Uncaught TypeError: Cannot call method 'setup' of undefined
http://translatewiki.net/w/extensions/Kieli/ext.kieli.js:4
4 mw.toolbar is undefined
https://translatewiki.net/w/i.php?title=MediaWiki:Gadget-editbuttons.js&action=raw&ctype=text/javascript&3337614:98
14 Uncaught ReferenceError: hookEvent is not defined
http://translatewiki.net/w/i.php?title=MediaWiki:Gadget-prota.js&action=raw&ctype=text/javascript&924496:39
20 addOnloadHook is not defined
https://translatewiki.net/w/i.php?title=MediaWiki:Gadget-MsgToPortal.js&action=raw&ctype=text/javascript&3585808:20
22 Uncaught ReferenceError: addOnloadHook is not defined
http://translatewiki.net/w/i.php?title=MediaWiki:Gadget-translatetab.js&action=raw&ctype=text/javascript&3585797:11
23 addOnloadHook is not defined
https://translatewiki.net/w/i.php?title=MediaWiki:Gadget-renameuser.js&action=raw&ctype=text/javascript&3585802:2
23 addOnloadHook is not defined
https://translatewiki.net/w/i.php?title=MediaWiki:Gadget-setuserrights.js&action=raw&ctype=text/javascript&3585786:16
34 mw.toolbar is undefined
http://translatewiki.net/w/i.php?title=MediaWiki:Gadget-editbuttons.js&action=raw&ctype=text/javascript&3337614:98
39 addOnloadHook is not defined
https://translatewiki.net/w/i.php?title=MediaWiki:Gadget-translatetab.js&action=raw&ctype=text/javascript&3585797:11
</pre>
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
