"Duplicatebug" posted a comment on MediaWiki.r96546. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96546#c29087
Commit summary for MediaWiki.r96546: Enabled MoveLogFormatter -> This brings better i18n even to existing move log entries Fixed the class name from r96441, it's Move not Block Added notes about new naming conventions to DefaultSettings.php -> didn't bother the remain existing messages now, they will keep working Didn't remove 1movedto2*, they are still used until I commit the code which actually makes new style log entries. Duplicatebug's comment: This queries are used for each gender parser function: <pre> <!--SELECT * FROM `user` WHERE user_id = '1' LIMIT 1 (MediaWiki::run/MediaWiki::main/MediaWiki::performRequest/SpecialPageFactory::executePath/SpecialLog::execute/SpecialLog::show/IndexPager::getBody/LogPager::formatRow/LogEventsList::logLine/LogFormatter::getActionText/Message::escaped/Message::toString/Message::transformText/MessageCache::transform/Parser::transformMsg/Parser::preprocess/Parser::replaceVariables/PPFrame_DOM::expand/Parser::braceSubstitution/call_user_func_array/CoreParserFunctions::gender/User::getOption/User::loadOptions/User::load/User::loadFromId/User::loadFromDatabase/DatabaseBase::selectRow/DatabaseBase::select)--> <!--SELECT ug_group FROM `user_groups` WHERE ug_user = '1' (MediaWiki::run/MediaWiki::main/MediaWiki::performRequest/SpecialPageFactory::executePath/SpecialLog::execute/SpecialLog::show/IndexPager::getBody/LogPager::formatRow/LogEventsList::logLine/LogFormatter::getActionText/Message::escaped/Message::toString/Message::transformText/MessageCache::transform/Parser::transformMsg/Parser::preprocess/Parser::replaceVariables/PPFrame_DOM::expand/Parser::braceSubstitution/call_user_func_array/CoreParserFunctions::gender/User::getOption/User::loadOptions/User::load/User::loadFromId/User::saveToCache/User::loadGroups/DatabaseBase::select)--> <!--SELECT * FROM `user_properties` WHERE up_user = '1' (MediaWiki::run/MediaWiki::main/MediaWiki::performRequest/SpecialPageFactory::executePath/SpecialLog::execute/SpecialLog::show/IndexPager::getBody/LogPager::formatRow/LogEventsList::logLine/LogFormatter::getActionText/Message::escaped/Message::toString/Message::transformText/MessageCache::transform/Parser::transformMsg/Parser::preprocess/Parser::replaceVariables/PPFrame_DOM::expand/Parser::braceSubstitution/call_user_func_array/CoreParserFunctions::gender/User::getOption/User::loadOptions/User::load/User::loadFromId/User::saveToCache/User::loadOptions/DatabaseBase::select)--> </pre> More information: The performer of the logs makes now problems. They are handled by one query (the LinkBatch in LogPager::getStartBody). The problem are links to user pages inside the comments which are not performer (Linker::commentBlock). Than each link result in an own query to get the gender state. But that sounds hard to do at that place. For block log entries the method Linker::userToolLinks is using the user talk page, which is not inside the LinkBatch and Linker::getTitleLink is calling User::idFromName for each entry. There is not for every user the need to add usernames of (partial) rev deleted log entries to the linkbatch, but that sounds not so easy to do. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
