"Platonides" changed the status of MediaWiki.r107028 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107028#c29126
Old Status: ok > New Status: fixme Commit summary for MediaWiki.r107028: * FU r106752: de-uglified Setup.php by moving most of the b/c code into FileBackendGroup. Deferred registration of file backends and lock managers to the respective singleton() functions for the group objects. * Refactored FileRepo::initZones() to require the specific zones; nothing was using it differently. * Removed deleted zone check in deleteBatch(), a similar error will instead trigger with the initZones() call as needed. * Added $wgLocalFileRepo comment. * Updated tests. Platonides's comment: $wgLockManagers is missing from DefaultSettings. I don't see why it needs to be a settings, if it's going to be set in Setup.php If its goal is to provide a way for extensions to register new lock types, surely it could be done with a hook instead. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
