"Reedy" posted a comment on MediaWiki.r108363. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108363#c29152
Commit summary for MediaWiki.r108363: * bug 33571: fix yottabits/s in Language::formatBitrate Problem was caused by inexact floating-point comparisons with values returned from log10(); worked around by simply duplicating the very similar code in the function immediately below, which does the same thing with 1024 instead of 1000 unit sizes, uses only simple division, and passes the test cases. Reedy's comment: I was thinking about normalising the code when I was adding to it... The difference between the 2 blocks of code is 1000 vs 1024, and then different message keys, so could refactor most of it out... _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
