"Krinkle" posted a comment on MediaWiki.r108312. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108312#c29157
Commit summary for MediaWiki.r108312: Don't expand templates in html <title>. This seems to have regressed some time ago. Krinkle's comment: This seems to fix the problem, and still looks safe: <syntaxhighlight lang="diff"> Index: OutputPage.php =================================================================== --- OutputPage.php (revision 108368) +++ OutputPage.php (working copy) @@ -813,7 +813,7 @@ # change "<i>foo&bar</i>" to "foo&bar" - $this->setHTMLTitle( $this->msg( 'pagetitle' )->rawParams( htmlspecialchars( Sanitizer::stripAllTags( $nameWithTags ) ) ) ); + $this->setHTMLTitle( $this->msg( 'pagetitle' )->rawParams( Sanitizer::stripAllTags( $nameWithTags ) )->escaped() ); } </syntaxhighlight> _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
