"Catrope" changed the status of MediaWiki.r106965 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106965#c29245
Old Status: new
> New Status: fixme
Commit summary for MediaWiki.r106965:
AFTv5 - enable use of feedback properties table to store user edit counts (if
user is logged in).
Catrope's comment:
<pre>
// I'd really rather have this passed in, to save a query,
+ // and rule out consistency problems, but there doesn't seem
+ // to be a way to do 'RETUNING af_id' on the insert, or to
+ // pre-increment the ID column (since it's a MySQL auto-
+ // increment, not a sequence) before the insert.
</pre>
There is a way to do this, actually. Use <code>$afid = $dbw->insertId();</code>
right after the INSERT query. Marking fixme because this is vulnerable to race
conditions, and generally more complicated than it needs to be. OK otherwise.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
