"Catrope" changed the status of MediaWiki.r108039 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108039#c29248
Old Status: new
> New Status: fixme
Commit summary for MediaWiki.r108039:
Added link option D:
- modules/ext.articleFeedbackv5/ext.articleFeedbackv5.js:
- Added link option D
- Added tracking ID "bottomright-link"
- modules/ext.articleFeedbackv5/ext.articleFeedbackv5.css:
- Added styles for link option D (mostly copied from option C,
without
the rotation)
- ArticleFeedbackv5.php:
- Updated options for $wgArticleFeedbackv5LinkBuckets
- ArticleFeedbackv5.i18n.php:
- Added "articlefeedbackv5-bottomrighttab-linktext" for link
option D
- ArticleFeedbackv5.hooks.php:
- Added "articlefeedbackv5-bottomrighttab-linktext" to messages
for
ext.articleFeedbackv5
Catrope's comment:
<pre>
+ .html( mw.msg( 'articlefeedbackv5-bottomrighttab-linktext' ) )
</pre>
Should use <code>.text()</code> .
<pre>
+ $bottomRightTab.addClass( 'articleFeedbackv5-bottomrighttab' );
+ $bottomRightTab.find( '#articleFeedbackv5-bottomrighttabbox'
).addClass( 'articleFeedbackv5-bottomrighttabbox' );
+ $bottomRightTab.find( '#articleFeedbackv5-bottomrighttablink'
).addClass( 'articleFeedbackv5-bottomrighttablink' );
</pre>
Why are you adding these classes using jQuery, can't you add them in the HTML
you're using to construct <code>$bottomRightTab</code> instead?
Marking fixme for the .html()/.text() thing, OK otherwise.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
