"Catrope" changed the status of MediaWiki.r108482 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108482#c29249
Old Status: new
> New Status: fixme
Commit summary for MediaWiki.r108482:
Fix up AFTv5 feedback page (somewhat) - match mockups a bit better, more
sensible HTML generation (still would rather have this in the JS than the PHP,
but as I said, this is only somewhat fixed up), stub out abuse/spam filtering,
add a couple of columns from alter.sql that didn't make it into the main sql
file, and add some new translations.
Catrope's comment:
<pre>
+ 'articlefeedbackv5-special-add-feedback' => 'Add Your feedback',
</pre>
Don't Use Too Many Capitals, Our I18n People Don't Like It When You Do That.
<pre>
+ if( isset( $wgArticleFeedbackv5MaxCommentLength ) ) {
</pre>
Do not use isset() on a global variable, ever. Instead, unconditionally set it
in the setup file, and invent a magic value (like false or -1) to indicate that
there is no limit.
<pre>
+ .$this->msg(
'articlefeedbackv5-special-sort-label-before' )
</pre>
This uses the implicit toString method of the message object, don't do this.
Use <code>$this->msg( '....' )->escaped()</code> in this case.
<pre>
+ .implode( wfMessage( 'pipe-separator' )->escaped(),
$sortLabels )
</pre>
Don't mix <code>$this->msg()</code> and <code>wfMessage()</code> (they have the
same behavior, but one is global and the other is tied to a context), be
consistent.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
