"Catrope" changed the status of MediaWiki.r108454 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108454#c29292
Old Status: ok
> New Status: fixme
Commit summary for MediaWiki.r108454:
followup to -r108187 - Checking isset instead of 1/0 for checkbox, adding
myresponse/showunanswered to query parameter
Catrope's comment:
<pre>
+ if ( isset( $params['myresponse'] ) ) {
</pre>
Don't do it this way. Instead, define the parameters as booleans (with
<code>'myresponse' => false,</code> as the parameter definition), then use
<code>if( $params['myresponse'] ) {</code> .
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
