"Catrope" changed the status of MediaWiki.r108552 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108552
Old status: new > New status: ok Commit summary for MediaWiki.r108552: [MoodBar] More clean up * Hoist all variables together to the top of each scope, to prevent more/future leakage of globals such as fixed in r108533 -- JavaScript does this at run-time if not already, helps debugging when written the way the language works. One var statement per function, at the top. * Using $.ajax instead of $.post().error() * Cache repetitive query in $fbdFiltersCheck, no need to query that again and again (if it is live, then it also be bound live, which it isn't) * Re-use cached selector through chain for $( '#fbd-list' ). * Using <a target> _blank instead of _new. "_new" does not exist in any modern browser. "_blank" is a magic word that always forced a new window for the target. "_new" is actually a named window that is not found and usually opens a new window, except when another link with _new is clicked, which will then inconveniently hijack the other window that was opened via a _new link. * Follows-up r108533 _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
