"Hashar" posted a comment on MediaWiki.r108343.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108343#c29317

Commit summary for MediaWiki.r108343:

[mw.config] wgAction shouldn't use direct URL values
* Fixes bug 25800
* Depends on r108342

Hashar's comment:

> ''However I believe that this should make sure that $mediaWiki is actually 
> set, I don't believe that it's existence should be required for a page to be 
> rendered. We can build pages in other ways.''

Yeah that was my concern. This change, and the other, add a dependency to 
OutputPage :-(

Maybe the action could be passed as a function argument or on construction.



_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to