"Catrope" changed the status of MediaWiki.r108559 to "new" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108559#c29324
Old Status: fixme
> New Status: new
Commit summary for MediaWiki.r108559:
MERGE branches/concurrency 108301:108557 into trunk
Catrope's comment:
Breaks unit tests:
<pre>
[exec] There was 1 error:
[exec]
[exec] 1) ConcurrencyCheckTest::testStatus
[exec] DBQueryError: A database error has occurred. Did you forget to run
maintenance/update.php after upgrading? See:
https://www.mediawiki.org/wiki/Manual:Upgrading#Run_the_update_script
[exec] Query: SELECT * FROM unittest_concurrencycheck WHERE
cc_resource_type = 'CCUnitTest' AND (cc_record IN (1337,1338,1339,13310)) AND
(cc_expiration > unix_timestamp(now()))
[exec] Function: ConcurrencyCheck::status
[exec] Error: 1 no such function: now
[exec] #0
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/includes/db/Database.php(888):
DatabaseBase->reportQueryError('no such functio...', 1, 'SELECT * FROM...',
'ConcurrencyChec...', false)
[exec] #1
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/includes/db/Database.php(1361):
DatabaseBase->query('SELECT * FROM...', 'ConcurrencyChec...')
[exec] #2
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/includes/ConcurrencyCheck.php(258):
DatabaseBase->select('concurrencychec...', Array, Array, 'ConcurrencyChec...',
Array)
[exec] #3
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/includes/ConcurrencyCheckTest.php(95):
ConcurrencyCheck->status(Array)
[exec] #4 [internal function]: ConcurrencyCheckTest->testStatus()
[exec] #5 /usr/share/php/PHPUnit/Framework/TestCase.php(738):
ReflectionMethod->invokeArgs(Object(ConcurrencyCheckTest), Array)
[exec] #6 /usr/share/php/PHPUnit/Framework/TestCase.php(628):
PHPUnit_Framework_TestCase->runTest()
[exec] #7 /usr/share/php/PHPUnit/Framework/TestResult.php(666):
PHPUnit_Framework_TestCase->runBare()
[exec] #8 /usr/share/php/PHPUnit/Framework/TestCase.php(576):
PHPUnit_Framework_TestResult->run(Object(ConcurrencyCheckTest))
[exec] #9
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiTestCase.php(70):
PHPUnit_Framework_TestCase->run(Object(PHPUnit_Framework_TestResult))
[exec] #10 /usr/share/php/PHPUnit/Framework/TestSuite.php(757):
MediaWikiTestCase->run(Object(PHPUnit_Framework_TestResult))
[exec] #11 /usr/share/php/PHPUnit/Framework/TestSuite.php(733):
PHPUnit_Framework_TestSuite->runTest(Object(ConcurrencyCheckTest),
Object(PHPUnit_Framework_TestResult))
[exec] #12 /usr/share/php/PHPUnit/Framework/TestSuite.php(693):
PHPUnit_Framework_TestSuite->run(Object(PHPUnit_Framework_TestResult), false,
Array, Array, false)
[exec] #13 /usr/share/php/PHPUnit/Framework/TestSuite.php(693):
PHPUnit_Framework_TestSuite->run(Object(PHPUnit_Framework_TestResult), false,
Array, Array, false)
[exec] #14 /usr/share/php/PHPUnit/TextUI/TestRunner.php(305):
PHPUnit_Framework_TestSuite->run(Object(PHPUnit_Framework_TestResult), false,
Array, Array, false)
[exec] #15 /usr/share/php/PHPUnit/TextUI/Command.php(188):
PHPUnit_TextUI_TestRunner->doRun(Object(PHPUnit_Framework_TestSuite), Array)
[exec] #16
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiPHPUnitCommand.php(44):
PHPUnit_TextUI_Command->run(Array, true)
[exec] #17
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/phpunit.php(60):
MediaWikiPHPUnitCommand::main()
[exec] #18 {main}
[exec]
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/includes/db/Database.php:921
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/includes/db/Database.php:888
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/includes/db/Database.php:1361
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/includes/ConcurrencyCheck.php:258
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/includes/ConcurrencyCheckTest.php:95
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiTestCase.php:70
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiPHPUnitCommand.php:44
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/phpunit.php:60
[exec]
[exec] --
[exec]
[exec]
[exec] There were 5 failures:
[exec]
[exec] 1) DatabaseSqliteTest::testUpgrades
[exec] Different tables upgrading from 1.15 to 1.19alpha
[exec] Failed asserting that two arrays are equal.
[exec] --- Expected
[exec] +++ Actual
[exec] @@ @@
[exec] [3] => change_tag
[exec] - [4] => concurrencycheck
[exec] - [5] => config
[exec] - [6] => external_user
[exec] - [7] => externallinks
[exec] - [8] => filearchive
[exec] - [9] => hitcounter
[exec] - [10] => image
[exec] - [11] => imagelinks
[exec] - [12] => interwiki
[exec] - [13] => ipblocks
[exec] - [14] => iwlinks
[exec] - [15] => job
[exec] - [16] => l10n_cache
[exec] - [17] => langlinks
[exec] - [18] => log_search
[exec] - [19] => logging
[exec] - [20] => module_deps
[exec] - [21] => msg_resource
[exec] - [22] => msg_resource_links
[exec] - [23] => objectcache
[exec] - [24] => oldimage
[exec] - [25] => page
[exec] - [26] => page_props
[exec] - [27] => page_restrictions
[exec] - [28] => pagelinks
[exec] - [29] => protected_titles
[exec] - [30] => querycache
[exec] - [31] => querycache_info
[exec] - [32] => querycachetwo
[exec] - [33] => recentchanges
[exec] - [34] => redirect
[exec] - [35] => revision
[exec] - [36] => site_stats
[exec] - [37] => tag_summary
[exec] - [38] => templatelinks
[exec] - [39] => text
[exec] - [40] => transcache
[exec] - [41] => updatelog
[exec] - [42] => uploadstash
[exec] - [43] => user
[exec] - [44] => user_former_groups
[exec] - [45] => user_groups
[exec] - [46] => user_newtalk
[exec] - [47] => user_properties
[exec] - [48] => valid_tag
[exec] - [49] => watchlist
[exec] + [4] => config
[exec] + [5] => external_user
[exec] + [6] => externallinks
[exec] + [7] => filearchive
[exec] + [8] => hitcounter
[exec] + [9] => image
[exec] + [10] => imagelinks
[exec] + [11] => interwiki
[exec] + [12] => ipblocks
[exec] + [13] => iwlinks
[exec] + [14] => job
[exec] + [15] => l10n_cache
[exec] + [16] => langlinks
[exec] + [17] => log_search
[exec] + [18] => logging
[exec] + [19] => module_deps
[exec] + [20] => msg_resource
[exec] + [21] => msg_resource_links
[exec] + [22] => objectcache
[exec] + [23] => oldimage
[exec] + [24] => page
[exec] + [25] => page_props
[exec] + [26] => page_restrictions
[exec] + [27] => pagelinks
[exec] + [28] => protected_titles
[exec] + [29] => querycache
[exec] + [30] => querycache_info
[exec] + [31] => querycachetwo
[exec] + [32] => recentchanges
[exec] + [33] => redirect
[exec] + [34] => revision
[exec] + [35] => site_stats
[exec] + [36] => tag_summary
[exec] + [37] => templatelinks
[exec] + [38] => text
[exec] + [39] => transcache
[exec] + [40] => updatelog
[exec] + [41] => uploadstash
[exec] + [42] => user
[exec] + [43] => user_former_groups
[exec] + [44] => user_groups
[exec] + [45] => user_newtalk
[exec] + [46] => user_properties
[exec] + [47] => valid_tag
[exec] + [48] => watchlist
[exec] )
[exec]
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/includes/db/DatabaseSqliteTest.php:211
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiTestCase.php:70
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiPHPUnitCommand.php:44
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/phpunit.php:60
[exec]
[exec] 2) ConcurrencyCheckTest::testCheckoutCheckin
[exec] Checkout of locked resource fails as different user
[exec] Failed asserting that <boolean:true> is false.
[exec]
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/includes/ConcurrencyCheckTest.php:58
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiTestCase.php:70
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiPHPUnitCommand.php:44
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/phpunit.php:60
[exec]
[exec] 3) ConcurrencyCheckTest::testExpire
[exec] Resource expiration
[exec] Failed asserting that <integer:0> matches expected <integer:2>.
[exec]
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/includes/ConcurrencyCheckTest.php:82
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiTestCase.php:70
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiPHPUnitCommand.php:44
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/phpunit.php:60
[exec]
[exec] 4) ApiConcurrencyTest::testCheckOut
[exec] Failed asserting that two strings are equal.
[exec] --- Expected
[exec] +++ Actual
[exec] @@ @@
[exec] -failure
[exec] +success
[exec]
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/includes/api/ApiConcurrencyTest.php:97
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiTestCase.php:70
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiPHPUnitCommand.php:44
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/phpunit.php:60
[exec]
[exec] 5) ApiConcurrencyTest::testCheckIn
[exec] Failed asserting that two strings are equal.
[exec] --- Expected
[exec] +++ Actual
[exec] @@ @@
[exec] -success
[exec] +failure
[exec]
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/includes/api/ApiConcurrencyTest.php:143
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiTestCase.php:70
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiPHPUnitCommand.php:44
[exec]
/var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/phpunit.php:60
[exec]
</pre>
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
