Skipping most of this, but there's a few I at least have an answer for.
On Thu, Jan 12, 2012 at 11:31 AM, Daniel Barrett <[email protected]> wrote:
> 1. The global variable $action disappeared, breaking a bunch of our
> extensions. I switched to $wgRequest->getVal('action').
>
This may have been available in the global context, but as far as I know it
was never documented as a stable global that should be used.
> 2. The removal of Xml::hidden() caused one of our extensions to break.
> I switched to Xml::input(..., array('type', 'hidden'))
>
Xml::hidden() was removed entirely? There *is* Html::hidden() which should be
functionally similar.
> 5. The removal of $wgMessageCache->addMessage() broke many extensions,
> some ours and some from mediawiki.org like SimpleForms. Some fixes just
> required use of the i18n file. Our more difficult issue was that we were
> injecting system messages into articles to add tracking categories. On advice
> from this list (thanks!), we used code patterned after
> Parser::addTrackingCategory() to inject categories and it works fine,
> actually much better than what we had.
>
MessageCache::addMessages() has been on a clear deprecation path for awhile
now and should've been well-documented. Even before it was removed entirely,
it should've already been a no-op.
> 8. Our MediaWiki:common.js stopped running on the login page. I realize
> this was a security fix; it just took me by surprise. Fixed by writing a
> custom extension using the hook UserLoginForm to inject the few lines of JS
> we needed, and I'm evaluating other non-JS solutions for more security.
>
This hasn't changed any time recently as far as I can tell...we've had this
in place for quite awhile.
-Chad
_______________________________________________
Wikitech-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
