"Reedy" posted a comment on MediaWiki.r108778.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108778#c29429

Commit summary for MediaWiki.r108778:

Added spam and abuse filtering:
* NB: AbuseFilter setup tested with a simple filter using action=feedback.
*     AbuseFilter consequences are not used.
*     Existing AbuseFilter edit filters are not triggered on new feedback.
        - ArticleFeedbackv5.i18n.php:
                - Added messages 'articlefeedbackv5-error-abuse',
                  'articlefeedbackv5-error-abuse-linktext', and
                  'articlefeedbackv5-error-abuse-link'
        - ArticleFeedbackv5.hooks.php:
                - Updated module messages to include the new ones
        - modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js:
                - Updated the error handler on submitForm() to create the abuse
                  feedback link
        - ApiArticleFeedbackv5:
                - Removed call to abuse stub from validateParam() and replaced 
it with
                  just the length check
                - Removed method validateText()
                - New method findAbuse()
                - Added a call to findAbuse() immediately after param validation

Reedy's comment:

You should probably conditionalise the usage of AbuseFilter (based on whether 
the classes exist).

Chances are someone is going to come along and want to use it on a wiki with no 
AbuseFilter

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to