"Aaron Schulz" changed the status of MediaWiki.r108274 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108274#c29438
Old Status: new > New Status: fixme Commit summary for MediaWiki.r108274: * Added WikiPage to RequestContext and related so that it can be shared to avoid creating a new object each time and thus avoiding database queries to load the state of the object * Added Article::getPage() as accessor to the WikiPage object so that it can be set in the context from MediaWiki::initializeArticle() * Use it WikiPage::main() to call doViewUpdates() I'm doing to this now so that I can revert r105790 and use the WikiPage object before the 1.19 release Aaron Schulz's comment: <pre>$this->context->getWikiPage()->doViewUpdates( $this->context->getUser() );</pre> This assumes that only wikipages are cacheable. I'd rather this be a bit more general, such as being able to check *if* a wikipage is set first. This relates to the exception problem. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
