"Nikerabbit" changed the status of MediaWiki.r88633 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88633#c29449
Old Status: resolved > New Status: fixme Commit summary for MediaWiki.r88633: * In core: ** Added hooks for custom RC/newpages filters ** Added tables,fields,and join_conds to SpecialNewPagesConditions hook ** Removed superflous $nameSpace logic in watchlist code ** Removed some copy-paste code for RC/watchlist filters ** Updates hooks.txt * In FlaggedRevs: * Added "hide reviewed edits" filter to RC/newpages * Combined two handlers into modifyChangesListQuery. Removed is_array() check - always true now. * Fixed onBeforePageDisplay() so that CSS worked on sp:Watchlist * @TODO: remove $wgUseRCPatrol stuff...this gets us closer. Nikerabbit's comment: Reproduce-able notices with urls like: http://translatewiki.net/w/i.php?target=1%29%20declare%20%40q%20varchar%288000%29%20select%20%40q%20%3D%200x57414954464F522044454C4159202730303A30303A313527%20exec%28%40q%29%20--&title=Special:RecentChangesLinked/Main_Page&feed=atom Notices like: [13-Jan-2012 08:47:52] PHP Warning: Invalid argument supplied for foreach() in /www/w/includes/specials/SpecialRecentchanges.php on line 816 The way the customFilters is used elsewhere but depends on call to setup() to have it initialized looks very fragile. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
