"Nikerabbit" changed the status of MediaWiki.r98878 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98878
Old status: new > New status: ok Commit summary for MediaWiki.r98878: [RL2] Followup r96837, prevent requests for nonexistent modules from polluting the gadget names cache by caching nonexistence separately. For more details about the bug this was causing, see CR comments on r96837. * Introduce LocalGadgetRepo::$missCache that caches nonexistence of gadgets * Use $data for caching existing gadgets only * In memcached, continue to cache nonexistence by storing an empty array. This requires some logic to ensure the right object member is updated * Document the in-object caching vars * Fix clearInObjectCache() to really clear everything * When deleting a gadget, set its cache entry to an empty array rather than removing it * Update $missCache for modifications and deletions too * Add an optimization where all gadgets that aren't in $data are (rightly) assumed no to exist if $idsLoaded is true _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
