"Reedy" changed the status of MediaWiki.r102253 to "deferred" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102253
Old status: new > New status: deferred Commit summary for MediaWiki.r102253: * Made blocking mode the default. Testing indicates that the non-blocking mode has unacceptably high packet loss, presumably because the backlog buffer is only 64KB, meaning that pipes can only stall for about 1ms before they lose data. * Fixed a bug in Block::Offset() causing an overrun exception to be thrown when there is no overrun. * In PipeProcessor::CopyFromPipe(), fixed a bug causing incorrect loss reports. * Several fixes for blocking pipes: ** Don't drop blocks for blocking pipes, except when the pipe is closed and scheduled for reopening. ** Several changes in support: don't add blocking pipes to epoll, expose IsBlocking() interface, move "blocking" member variable from PipeProcessor to LogProcessor ** Don't put blocking pipes on holiday. ** Handle EINTR in write() correctly. In non-blocking mode EINTR is probably not possible. ** If write() returns less than the expected number of bytes in blocking mode, continue trying with the remaining part of the block. This is probably unnecessary, I just threw it in to be complete. * Added a test program "slowpipe", similar to slowread except that it copies data to stdout instead of throwing it away. * In udp2log.cpp, fixed the add_options() call, default_value() is not necessary. Fixed the usage message. * Made report interval configurable, with a default of 5 mins which is more suitable for production than the previous default of 5 seconds. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
