"Khorn (WMF)" posted a comment on Wikimedia.r1151.
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1151#c29492
Commit summary for Wikimedia.r1151:
Modifying _queue2civicrm_normalize_msg to ignore missing contribution_tracking
ids for checks. Also fixing payment_method detection. FU r229
Khorn (WMF)'s comment:
<pre>+ $contribution_tracking_id =
_queue2civicrm_insert_contribution_tracking( $msg['payment_method'], 'civicrm',
date('YmdHis', (int) $msg[ 'date' ] ), null, $optout, $anonymous ); //ACK! this
should not be handled this way! should be dynamic!</pre>
That first parameter should be a utm source, and not just the payment method.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
