"Krinkle" posted a comment on MediaWiki.r108222. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108222#c29542
Commit summary for MediaWiki.r108222: Set position => 'top' for wikibits, required to support legacy gadgets. Spotted by Niklas on TranslateWiki. Ping r107327. Krinkle's comment: Afaik this is not needed. At least not for regression purposes. On several wikis gadgets were given [dependencies=mediawiki.legacy.wikibits] since the race condition was already happening (at least on Commons there were complaints). I have no problem with conveniencing users with this, but since those gadgets were likely already breaking under some circumstances (slow connections, error in a module, any race condition or js error), we might keep it that way and require dependencies to be properly declared and shaving a little (wiki)bit from the top queue. Gain is minimal, but it's more a principle thing I guess. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
