"Santhosh.thottingal" posted a comment on MediaWiki.r108816.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108816#c29607

Commit summary for MediaWiki.r108816:

Do proper checks for duplicate unit names instead of dying with SQL error.
Also check the validity of unit names that come from page source, they can be 
tampered by users and cannot be trusted.
In the non-latest error message, link the revision number to oldid of that page.

Santhosh.thottingal's comment:

tpt-duplicate can be better shown as error or warning, if possible close to the 
textbox with duplicate translation unit name.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to