"Hashar" changed the status of MediaWiki.r107982 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107982#c29628
Old Status: new
> New Status: fixme
Commit summary for MediaWiki.r107982:
[jquery.footHovzer] new plugin for mw-log-console and mw-debug-toolbar
* Previously mw.log and mw.Debug both were in a fixed container on the bottom,
overlapping each other. mw.log did increase the body's padding-bottom to
account for the height so that all content is still visible, but it was still a
problem when mw.Debug came along.
* This plugin adds a single fixed position element to bottom of the body, to
which other stuff like mw.log and mw.Debug can append a non-fixed position
container. That will take care of it.
* Method update() will re-check the padding and scroll position and fix where
needed
* Reduces code a little bit
Hashar's comment:
This has a really strange behavior which make the text jump in an unattended
way anytime I click on a bar. It looks like the main content bottom is aligned
to the top of the toolbar. Whenever the toolbar change of size (when a tab is
hidden, tab content differs in height), that make the text jump up or down.
That makes the whole window move which is really tiring to the eye. I would
expect the main content to stick to the top of the window. Much like when
Firebug toolbar is shown / hidden.
Here what I did using wgDebugToolbar on a long page:
* first click on a tab : jump the text to the top (likely a bug)
* I then scroll down the text back to the original position, click another tab
with longer content : the text jump up :b
The following code in jquery/jquery.footHovzer.js causes the screen to jump in
an unattended way. By commenting it out, the text stop moving up/down :-)
// Update scroll so that page stays focusses on same area
winTop = $(window).scrollTop();
if ( $(document).height() - $(window).height() > winTop ) {
$(window).scrollTop( winTop + ( newHeight - prevHeight ) );
}
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
