"MaxSem" changed the status of MediaWiki.r108106 to "ok" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108106#c29762

Old Status: new
> New Status: ok

Commit summary for MediaWiki.r108106:

move carrier options settings to wiki page

MaxSem's comment:

Swapping check order would allow getting rid of second condition in <tt>if ( 
strpos( $line, '*' ) === 0 && strpos( $line, '**' ) !== 0 && $i >= 0 )</tt>, 
otherwise looks ok.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to