"MaxSem" posted a comment on MediaWiki.r109111.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109111#c29810
Commit summary for MediaWiki.r109111:
Refactored SpamBlacklist to be extendable for other blacklist types
This is the groundwork for Bug 33761
MaxSem's comment:
* Although I admit I'm prone to abuse regexes too, $thisHttpRegex is not really
needed, strpos() will suffice.
* <tt>$cachedRegexes = $wgMemc->get( "$wgDBname:{$listType}_blacklist_regexes"
);</tt> - Use wfMemcKey(), it automatically prepends $wgDBname. Also please put
variable part of the key name to the end to make reading key names easier.
* getArticleText() gives me the creeps, but it was so before you.
* BaseBlocklist probably should have been called BlocklistBase per precendents.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
