"Hashar" posted a comment on MediaWiki.r109161. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109161#c29819
Commit summary for MediaWiki.r109161: deprecated $query2 in Title.php $query2 was used to pass a variant. Make that deprecated, the recommanded way is to use an array as a first parameter. Ex: $this->getLocalUrl( array( 'variant' => 'foo' ) ); Ping r105919 Hashar's comment: I the idea of r105919 was to not break back compatibility. Since any call of a public getter eventually end up calling fixUrlQueryArgs() I though it would be a good it to add the deprecation notice there. If you drop the second argument from the 4 callers, you will get PHP errors which is not really nice and my cause trouble with legacy extensions. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
