"Bsitu" posted a comment on MediaWiki.r109609.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109609#c29822
Commit summary for MediaWiki.r109609:
Split LogPager out of LogEventsList.php
Bsitu's comment:
<source lang="php">
if( count($types) ) {
$this->mConds['log_type'] = $types;
// Set typeCGI; used in url param for paging
if( count($types) == 1 ) $this->typeCGI = $types[0];
}
</source>
It's probably better to add curly brace to the if statement and not write
"blocks" as a single-line, also note that count($types) gets called twice
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
