"Umherirrender" posted a comment on MediaWiki.r91180. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91180#c29830
Commit summary for MediaWiki.r91180: Fixes for r88113 and some realted changes: * Modified <s>Article::editUpdates()</s> WikiPage::doEditUpdates() arguments to take a Revision object, an User object and options (much more readable that those boolean parameters) * Call isCountable() on the old content and pass it to WikiPage::doEditUpdates() with the 'oldcountable' option so that it really reflects the old state of the page * Updated all calls (no one in extensions) and removed the wrapper WikiPage::editUpdates() * Call onArticleEdit() and onArticleCreate() (the one that is of course) from doEditUpdates() * Removed $wgTitle hack from Import.php Umherirrender's comment: This revision breaks the REVISION* vars in WikiText after a nulledit (save without change), see bug 32948. <tt>$revision</tt> is now always created with current timestamp and than this object is used to reparse the page (in doEditUpdates). But than the current timestamp is used for the vars. REVISIONID is also empty, because for $changed = true the revision id in $revision is never set. But I am unsure why REVISIONUSER is also empty. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
