"Krinkle" changed the status of MediaWiki.r109144 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109144#c29838
Old Status: resolved
> New Status: fixme
Commit summary for MediaWiki.r109144:
Modify directly the style attr, .css didn't work - more tests passing now
Some whitespace and test comment cleanups
Krinkle's comment:
<blockquote style="font-style: italic;">Modify directly the style attr, .css
didn't work</blockquote>
<pre>
- $testElement.css( 'font-family', 'NonExistingFont, AnjaliOldLipi,
Arial, Helvetica, sans');
+ $testElement.attr( 'style','font-family: NonExistingFont,
AnjaliOldLipi, Arial, Helvetica, sans' );
</pre>
This is a problem imho. Considering that the main WebFonts module uses this
all-over:
<pre>
$body.css( 'font-family' )
..
$( '.webfonts-lang-attr' ).css( 'font-family', '' )
..
$( 'body, input, select, textarea' ).css(
'font-family', '"' + font + '", Helvetica,
Arial, sans-serif'
);
..
$(el).css( 'font-family', fontFamily )
</pre>
If that really doesn't work then the main module can't work either. Needs more
investigation, perhaps the test failure was not caused by this ?
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
