"Krinkle" changed the status of MediaWiki.r107951 to "new" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107951#c29952
Old Status: ok > New Status: new Commit summary for MediaWiki.r107951: Bug 29236 - Extension:Collection should copy the book title automatically to the stored "book page" input field Author: John N I took time to adapt John's patch to jQuery awesomeness and learned something about our js infrastructure in the process. Krinkle's comment: <code><nowiki><input id="personalCollTitle" (..)/></nowiki></code> and <code><nowiki><input id="titleInput" (..)/></nowiki></code> are both outputted by PHP. Since this is running only once on document ready, it'd make sense to change <tt>Collection.templates.php</tt> instead to output the initial value in both of them, instead of syncing them from JS after the page is loaded. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
