"Hashar" changed the status of MediaWiki.r109161 to "new" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109161#c29974
Old Status: fixme > New Status: new Commit summary for MediaWiki.r109161: deprecated $query2 in Title.php $query2 was used to pass a variant. Make that deprecated, the recommanded way is to use an array as a first parameter. Ex: $this->getLocalUrl( array( 'variant' => 'foo' ) ); Ping r105919 Hashar's comment: ''Rewriting my above comment /me needs a neurologist appointment.'' The idea of r105919 was to not break back compatibility. Since a call to any of the public getter eventually end up calling fixUrlQueryArgs(), I though it would be cleaner to add the deprecation notice there. If you drop the second argument from the 4 callers, you will get PHP errors which is not really nice and my cause trouble with legacy extensions. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
