"Catrope" changed the status of MediaWiki.r109933 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109933
Old status: new
> New status: ok
Commit summary for MediaWiki.r109933:
Updated survey CTA to use different links for options 1, 2, and 3:
- modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js:
- New method getSurveyUrl() for the survey CTA, to pull the
correct
survey link, or false if the form option was not 1, 2, or 3
- New method verify() for the survey CTA, to kick out if there
is no
appropriate survey link
- Updated build() to use getSurveyUrl() and send the feedback
id as the
parameter "c"
- ArticleFeedbackv5.php;
- Changed $wgArticleFeedbackv5SurveyUrl to
$wgArticleFeedbackv5SurveyUrls, a map of display buckets to
survey urls
- Removed old survey setup
- ArticleFeedbackv5.hooks.php:
- Updated to pass $wgArticleFeedbackv5SurveyUrls to the
resource loader
instead of $wgArticleFeedbackv5SurveyUrl
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
