"Krinkle" posted a comment on MediaWiki.r109977. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109977#c30021
Commit summary for MediaWiki.r109977: fixing bug 33931 with submitted patch - explicitly listing mw.user as a depenancy Krinkle's comment: Just FYI, chooseBanner is now immediately returning undefined. And in asychronous, the callback is called and the return falses are given to the mw.loader.using() callback not to whomever called chooseBanner(). Looks like chooseBanner is only called from an $.ajax success callback so looking good. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
