"Catrope" changed the status of MediaWiki.r108881 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108881#c30040
Old Status: new > New Status: fixme Commit summary for MediaWiki.r108881: AFTv5 Special page work - get rid of the COUNT and OFFSET queries via an additional rollup table (which works) and a continue parameter (which has some, uhh, issues). Tweaks to HTML and JS, to make class/ID names consistent, and make sure the CSS file works. Catrope's comment: <pre> -// $wgAPIListModules['articlefeedbackv5-view-ratings'] = 'ApiViewRatingsArticleFeedbackv5'; -// $wgAPIListModules['articlefeedbackv5-view-feedback'] = 'ApiViewFeedbackArticleFeedbackv5'; -// $wgAPIModules['articlefeedbackv5-flag-feedback'] = 'ApiFlagFeedbackArticleFeedbackv5'; +$wgAPIListModules['articlefeedbackv5-view-ratings'] = 'ApiViewRatingsArticleFeedbackv5'; +$wgAPIListModules['articlefeedbackv5-view-feedback'] = 'ApiViewFeedbackArticleFeedbackv5'; +$wgAPIModules['articlefeedbackv5-flag-feedback'] = 'ApiFlagFeedbackArticleFeedbackv5'; $wgAPIModules['articlefeedbackv5'] = 'ApiArticleFeedbackv5'; // Special Page -// $wgSpecialPages['ArticleFeedbackv5'] = 'SpecialArticleFeedbackv5'; -// $wgSpecialPageGroups['ArticleFeedbackv5'] = 'other'; +$wgSpecialPages['ArticleFeedbackv5'] = 'SpecialArticleFeedbackv5'; +$wgSpecialPageGroups['ArticleFeedbackv5'] = 'other'; </pre> This needs to be disabled as long as the special page is not ready. <pre> + $where[] = "$continueSql $continue"; </pre> Needs escaping of <code>$continue</code> . OK otherwise. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
